Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option and shortcode for Gitea version in documentation #7940

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

jolheiser
Copy link
Member

This PR would replace #7937, which gave me this idea.

Now the Gitea version would be stored in the Hugo config, and a shortcode would print it wherever it's used.
There would only be one place to update the Gitea version for documentation.

I may have gotten a little overzealous in my swapping.
The original idea was for the installing from binary page(s), but I made a few extra changes where I thought it wouldn't hurt to mention the "latest" version in examples.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@lunny
Copy link
Member

lunny commented Aug 22, 2019

Will replace #7937.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 22, 2019
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Aug 22, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2019
@lunny
Copy link
Member

lunny commented Aug 22, 2019

wait until 1.9.2 releases published by CI.

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #7940 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7940      +/-   ##
==========================================
- Coverage   41.46%   41.45%   -0.01%     
==========================================
  Files         478      478              
  Lines       63966    63966              
==========================================
- Hits        26521    26518       -3     
- Misses      33991    33993       +2     
- Partials     3454     3455       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f58187...05b1dce. Read the comment docs.

@lunny lunny merged commit 4ea9a37 into go-gitea:master Aug 23, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants