Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] times: use Index instead ID's and dont expose ID's #8833

Closed
6543 opened this issue Nov 5, 2019 · 2 comments · Fixed by #9200
Closed

[API] times: use Index instead ID's and dont expose ID's #8833

6543 opened this issue Nov 5, 2019 · 2 comments · Fixed by #9200
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Nov 5, 2019

While All Issue API Endpoints are structured like this:
/repos/{owner}/{repo}/issues/{index}/<endpoing> and use index
timetrack API is not:
/repos/{owner}/{repo}/issues/{id}/times

does this have any meanings?!?
@6543 6543 changed the title [Discusion] time track API for issues is not sonsistent with rest of issue APIS [Discusion] time track API for issues is not sonsistent with rest of issue API's Nov 5, 2019
@lunny lunny added modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Nov 5, 2019
@zeripath
Copy link
Contributor

zeripath commented Nov 5, 2019

We also need to add the ability to adjust time tracking. @6543 I think there were a couple of issues that referenced this.

@noerw
Copy link
Member

noerw commented Nov 20, 2019 •
edited
Loading

Another problem: the API returns internal IDs (user, issue ID), which is neither consistent with other APIs, nor meaningful to a data consumer. Should be username & issue index instead.

The following PR is blocked by this issue: https://gitea.com/gitea/tea/pulls/54

@6543 6543 mentioned this issue Nov 28, 2019
Merged
@6543 6543 changed the title [Discusion] time track API for issues is not sonsistent with rest of issue API's [API] times: use Index instead ID's and dont expose ID's Nov 28, 2019
@6543 6543 mentioned this issue Nov 28, 2019
Merged
19 tasks
zeripath pushed a commit that referenced this issue Dec 27, 2019
@6543 @zeripath
[API] Extend times API (#9200)
f2d03cd 
Extensively extend the times API.

close #8833; close #8513; close #8559
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[API] Extend times API 6543-forks/gitea
4 participants
@lunny @zeripath @noerw @6543