Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review page should not get refresh on adding comment #8861

Closed
2 of 7 tasks
atishhamte opened this issue Nov 7, 2019 · 3 comments · Fixed by #13877
Closed
2 of 7 tasks

Review page should not get refresh on adding comment #8861

atishhamte opened this issue Nov 7, 2019 · 3 comments · Fixed by #13877
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Milestone
1.14.0

Comments

@atishhamte
Copy link

  • Gitea version (or commit ref): 1.9.4
  • Git version: 2
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

On doing code review of pull request, on every comment, page is getting refresh. You can make use of AJAX kind to register the comment without refreshing the page.
This is very painful while reviewing files more than 100 with huge content.
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Nov 7, 2019
@stale
Copy link

stale bot commented Jan 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 6, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 6, 2020
@stale stale bot removed the issue/stale label Jan 6, 2020
@Unarelith Unarelith mentioned this issue Mar 7, 2020
Closed
@jpraet
Copy link
Member

jpraet commented Jun 27, 2020

+1, reviewing large pull requests is a real pain because of this

@andre161292
Copy link

This is a really annoying one, when reviewing large PRs. Would love to see activity here. :)

jpraet added a commit to kszbcss/gitea that referenced this issue Dec 6, 2020
@jpraet
go-gitea#8861 use ajax on PR review page
c45860a
@jpraet jpraet mentioned this issue Dec 6, 2020
Merged
@lafriks lafriks added this to the 1.14.0 milestone Dec 7, 2020
jpraet added a commit to jpraet/gitea that referenced this issue Dec 10, 2020
@jpraet
go-gitea#8861 use ajax on PR review page
9cf249b
lafriks added a commit that referenced this issue Jan 8, 2021
@jpraet @6543
@lunny @lafriks
Do not reload page after adding comments in Pull Request reviews (#13877
bcb7f35 
)

Fixed #8861 
* use ajax on PR review page

* handle review comments

* extract duplicate code

FetchCodeCommentsByLine was initially more or less copied from fetchCodeCommentsByReview. Now they both use a common findCodeComments function instead

* use the Engine that was passed into the method

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

Do not reload page after adding comments in Pull Request reviews jpraet/gitea
5 participants
@lunny @lafriks @andre161292 @jpraet @atishhamte