Fails again with read only config

[brandonkal]

• Gitea version (or commit ref):
• Git version:
• Operating system:
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Config should be considered immutable. Gitea should never attempt to save a value to app.ini

Error saving generated INTERNAL_TOKEN to custom config: open /data/gitea/c │
│ onf/app.ini: read-only file system

Gitea should exit when it finds a fatal error. There is no sense looping over that issue.

Screenshots

[lunny]

I think there is already an issue to report that.

[bagasme]

@lunny any issue that duplicate this?

[davidsvantesson]

I think previous issues/prs are closed and considered resolved.
@bagasme did you read under Create required directory structure? https://docs.gitea.io/en-us/install-from-binary/

[zeripath]

This is specific to docker. Gitea does exit when there is a fatal error.

The problem is that the way the docker is structured it will keep on trying to restart Gitea indefinitely.

[brandonkal]

Yes. The docker container should exit and leave the restart logic to the orchestrator (docker-compose/kubernetes)