Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updocker: ask s6 to stop all service when gitea stop #9171
Conversation
This comment has been minimized.
This comment has been minimized.
Tested (and fixed) ! Before :
After :
All services are stopped quickly after first fail and the container is stopped. |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Nov 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #9171 +/- ##
==========================================
+ Coverage 41.03% 41.03% +<.01%
==========================================
Files 553 553
Lines 72041 72041
==========================================
+ Hits 29564 29565 +1
- Misses 38744 38746 +2
+ Partials 3733 3730 -3
Continue to review full report at Codecov.
|
6e578dd
into
go-gitea:master
2 checks passed
2 checks passed
approvals/lgtm
this commit looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sapk commentedNov 27, 2019
•
edited
This should fix #9164 part of the container not stopping when gitea fail.
Follow : https://github.com/just-containers/s6-overlay#writing-an-optional-finish-script
Still WIP since I need to test it.