Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Notification] mentiont user on not-watching-repo = no notification #9233

Open
6543 opened this issue Dec 2, 2019 · 15 comments
Open
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@6543
Copy link
Member

6543 commented Dec 2, 2019

If a user is mentiont in a issue of a repo he is not watching he will get no notification

gitea version: master (23ef9ff)

should have nothing to do with permission since the instance-admin is also afected

@6543 6543 changed the title If a user is mentiont in a issue wich he is not watching he will get no notification [Bug] [Notification] mentiont user on not-watching-repo = no notification Dec 2, 2019
@guillep2k
Copy link
Member

Was that in master? The user needs to have read permissions on issues + e-mail notification enabled.

@6543
Copy link
Member Author

6543 commented Dec 3, 2019

@guillep2k sory for the les sinfos ... working on the empty issue dashboard!

@6543
Copy link
Member Author

6543 commented Dec 27, 2019

this bug is stil anoying and block work on gitea.com :(

@guillep2k
Copy link
Member

Sorry, @6543, I can't reproduce. With current master (b6fa229), I did the following:

  • I've created a public repo with user1 (user1/publicrepo).
  • With user1, I've created an issue in that repo with the following description: I mention @user2.
  • user2, who wasn't watching that repo, got a proper mail notification.
  • With user2, I set to watch user1/publicrepo. Then I set it to unwatch user1/publicrepo in order to created an explicit unwatch.
  • With user1, I've created a new issue with the following description: I mention @user2 again.
  • user2, who explicitly unwatched that repo, got a proper mail notification.

I didn't get anything in user2's dashboard, however. Is that what your issue is about?

@6543
Copy link
Member Author

6543 commented Jan 7, 2020

I'll look & test later :)

@6543
Copy link
Member Author

6543 commented Feb 12, 2020

tested with newest version:

  1. user1 create repo (or has one witch user2 not watching)
  2. user1 create issue
  3. user1 create comment "soething @user2"
  4. user2 get NO notify

also tested:

  1. user1 create repo (or has one witch user2 not watching)
  2. user1 create issue witch mention user2
  3. user2 get NO notify

PS: I didn't checked the mail notify but web-UI show no new notification

@6543
Copy link
Member Author

6543 commented Feb 19, 2020

@guillep2k just noticed yor question - yes its about gezing notify on UI too

@6543
Copy link
Member Author

6543 commented Mar 3, 2020

one of the next things I'll work on
I wokred on that ... but it had a other result ;)

@stale
Copy link

stale bot commented May 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added issue/stale and removed issue/stale labels May 2, 2020
@6543
Copy link
Member Author

6543 commented May 2, 2020

I'll test it this still is the case ...

@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 3, 2020
@6543
Copy link
Member Author

6543 commented Jul 4, 2020

Its in current master still the case

@stale stale bot removed the issue/stale label Jul 4, 2020
@stale
Copy link

stale bot commented Sep 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 2, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 2, 2020
@stale stale bot removed the issue/stale label Sep 2, 2020
@zeripath
Copy link
Contributor

zeripath commented Sep 2, 2020

Sorry @6543 I missed that you had confirmed that it was still present.

@6543
Copy link
Member Author

6543 commented Sep 2, 2020

well - if I had more time ... I could had looked at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

4 participants