AutoSubscribe to Issue when create or comment to it

[6543]

Fix #8243 auto subscribe issue on interact
try to fix issue #9233 (this is a independend bug)
close #8852

• add IssueWatchMode type

  • update functions

• correct Tests

• add Tests

• remove race when create/update IW

• migration

[6543]

also look at #9118

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@9f7148c). Click here to learn what that means.
The diff coverage is 67.4%.

@@           Coverage Diff            @@
##             master   #9535   +/-   ##
========================================
  Coverage          ?   43.7%           
========================================
  Files             ?     587           
  Lines             ?   81204           
  Branches          ?       0           
========================================
  Hits              ?   35493           
  Misses            ?   41313           
  Partials          ?    4398

Impacted Files	Coverage Δ
modules/indexer/code/indexer.go	42.62% <ø> (ø)
models/issue.go	53.82% <0%> (ø)
routers/home.go	46.8% <0%> (ø)
models/user.go	49.54% <0%> (ø)
models/user_mail.go	64.18% <100%> (ø)
modules/setting/indexer.go	91.89% <100%> (ø)
routers/repo/search.go	65.62% <100%> (ø)
modules/git/repo_language_stats.go	66.17% <100%> (ø)
modules/indexer/code/wrapped.go	40.74% <66.66%> (ø)
modules/indexer/code/bleve.go	64.7% <68.83%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7148c...f29de15. Read the comment docs.

[6543]

I think now it is more a feature or enhancement than a refactor can we change lables :)

[6543]

@guillep2k would be nice if you had time to look at it :)

[guillep2k]

My question is still standing: why are auto-watch subscriptions needed on issues when participants should be automatically notified anyway? Am I missing something? 🤔

gitea/modules/notification/mail/mail.go

Lines 42 to 44 in 5dc634d

	if err := mailer.MailParticipantsComment(comment, act, issue); err != nil {
	log.Error("MailParticipantsComment: %v", err)
	}

gitea/modules/notification/mail/mail.go

Lines 70 to 72 in 5dc634d

	if err := mailer.MailParticipants(issue, doer, actionType); err != nil {
	log.Error("MailParticipants: %v", err)
	}

etc.

I know that this doesn't cover the dashboard feed (action table), but subscribing the participants will make the code linked above redundant. Maybe we should remove that code and let subscriptions handle the notifications? If so, we'd need to auto-subscribe all participants in the migration step.

[6543]

I know that this doesn't cover the dashboard feed (action table), but subscribing the participants will make the code linked above redundant. Maybe we should remove that code and let subscriptions handle the notifications? If so, we'd need to auto-subscribe all participants in the migration step.

I would prefere if a action witch triger a email notification also create a notification for ui - this inconsistency is anoing for me

[guillep2k]

I would prefere if a action witch triger a email notification also create a notification for ui - this inconsistency is anoing for me

I understand that, but now there are two paths in which participants will be receiving email notifications: via issue_watch and via mailer.MailParticipants. It's redundant! I think we should either carefully ⑴ remove the "mail participants" logic from modules/notification/mailer or duplicate that logic in modules/notification/action for the dashboard feed, leaving the issue_watch table rest as it is.

⑴ I say "carefully" because there are several subtleties in how the emails are tailored for each notification type.

[6543]

@guillep2k I'll split up changes of this pull to make independent desicions about how UI & Mail Notifications are unifiedy and how to make this configurable

[6543]

since #10473 was merged ... should we still migrate db to use integer instead of bool ( move from is_watching to mode colum) so we can add different modes in future - if so I'll remove IssueWatchModeAuto for now and rebase?

EDIT: modesl like: "notify only on state-change" & "ignore mentions too" ...

[6543]

👍 for rebase and migrate
👎 for close this

@zeripath @guillep2k

[guillep2k]

I don't think this is needed after your other PR was merged. Unless there's something else I'm missing. 😁