-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add notification endpoint #9488
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9488 +/- ##
==========================================
+ Coverage 42.22% 42.22% +<.01%
==========================================
Files 587 587
Lines 77947 77947
==========================================
+ Hits 32915 32917 +2
Misses 40994 40994
+ Partials 4038 4036 -2
Continue to review full report at Codecov.
|
I didn't notice that you hadn't finished! that's what I get for reviewing whilst drinking! What you've written so far looks reasonable! 🎄 ☃️ Merry Christmas ☃️ 🎄 |
6693aae
to
5e58bdf
Compare
* add func GetNotifications(opts FindNotificationOptions) * add func (n *Notification) APIFormat() * add func (nl NotificationList) APIFormat() * add func (n *Notification) APIURL() * add func (nl NotificationList) APIFormat() * add LoadAttributes functions (loadRepo, loadIssue, loadComment, loadUser) * add func (c *Comment) APIURL() * add func (issue *Issue) GetLastComment() * add endpoint GET /notifications * add endpoint PUT /notifications * add endpoint GET /repos/{owner}/{repo}/notifications * add endpoint PUT /repos/{owner}/{repo}/notifications * add endpoint GET /notifications/threads/{id} * add endpoint PATCH /notifications/threads/{id}
@adelowo done |
close #4811
This is the main PR adding Notification Endpoint ...
[Spec Link]
Changes
GET /notifications
[spec]PUT /notifications
[spec]GET /repos/{owner}/{repo}/notifications
[spec]PUT /repos/{owner}/{repo}/notifications
[spec]GET /notifications/threads/{id}
[spec]PATCH /notifications/threads/{id}
[spec]future imprufements:
PATCH /notifications/threads/{id}
option to mark as pin/unread