Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-sqlite create not ignored dir #9517

Closed
6543 opened this issue Dec 27, 2019 · 3 comments · Fixed by #9515
Closed

make test-sqlite create not ignored dir #9517

6543 opened this issue Dec 27, 2019 · 3 comments · Fixed by #9515

Comments

@6543
Copy link
Member

6543 commented Dec 27, 2019

make test-sqlite create dir /modules/indexer/code/bleve.index/ wich is not in .gitignore

@6543
Copy link
Member Author

6543 commented Dec 27, 2019

removed from #9200 because of un-consencus if this should be added to .gitignore and/or make clean should handle it

@6543
Copy link
Member Author

6543 commented Dec 27, 2019

@lunny @zeripath point

@zeripath
Copy link
Contributor

We should simply not create it in the first place.

Any test that touches the source-code tree is broken. If I could figure out how to do it I'd make it a hard fail to write anything, ever, to the tree during a test. It should be absolutely not allowed.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants