Stop various tests from adding to the source tree

[zeripath]

Instead of just adding test generated files to .gitignore. We should prevent them from being produced in the first place.

No test should ever write to the source code tree!

Fixes #9517

[zeripath]

I wish there was an easy way to ensure that this does not happen. Perhaps we should be running the tests after chmoding the source tree to prevent this sort of behaviour?!

[sapk]

@zeripath We could do a similar check in CI than the css/js does (or did) for unchanged/added file to the git repo after the tests ran.

[zeripath]

Yeah I guess that's a reasonable thing to do but it doesn't prevent tests from creating files in the tree and then deleting them or just adding them to gitignore.

[zeripath]

@sapk something like this:

diff --git a/.drone.yml b/.drone.yml
index 7a844af8e..ae6a5f9b3 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -105,6 +105,7 @@ steps:
     image: golang:1.13
     commands:
       - make unit-test-coverage
+      - make test-check
     environment:
       GOPROXY: off
       TAGS: bindata sqlite sqlite_unlock_notify
@@ -122,6 +123,7 @@ steps:
     image: golang:1.13
     commands:
       - make test
+      - make test-check
     environment:
       GOPROXY: off
       TAGS: bindata sqlite sqlite_unlock_notify
@@ -150,6 +152,7 @@ steps:
     image: golang:1.13
     commands:
       - make test
+      - make test-check
     environment:
       GOPROXY: off
       TAGS: bindata
diff --git a/Makefile b/Makefile
index 146abf5d0..1b60997d0 100644
--- a/Makefile
+++ b/Makefile
@@ -200,6 +200,20 @@ fmt-check:
 .PHONY: test
 test:
        GO111MODULE=on $(GO) test -mod=vendor -tags='sqlite sqlite_unlock_notify' $(PACKAGES)
+       @echo "\n==>\033[32m Ok\033[m\n"
+
+.PHONY: test-check
+test-check:
+       @echo "Checking if tests have changed the source tree...";
+       @diff=$$(git status -s); \
+       if [ -n "$$diff" ]; then \
+               echo "make test has changed files in the source tree:"; \
+               echo "$${diff}"; \
+               echo "You should change the tests to create these files in a temporary directory."; \
+               echo "Do not simply add these files to .gitignore"; \
+               exit 1; \
+       fi;
+       @echo "==>\033[32m Ok\033[m\n";
 
 .PHONY: test\#%
 test\#%:

[zeripath]

I guess it just relies on us being eagle-eyed for changes to .gitignore?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@8841732). Click here to learn what that means.
The diff coverage is 40%.

@@           Coverage Diff            @@
##             master   #9515   +/-   ##
========================================
  Coverage          ?   41.6%           
========================================
  Files             ?     573           
  Lines             ?   75679           
  Branches          ?       0           
========================================
  Hits              ?   31487           
  Misses            ?   40280           
  Partials          ?    3912

Impacted Files	Coverage Δ
modules/indexer/issues/bleve.go	66.07% <40%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8841732...b75266f. Read the comment docs.