Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11.rc1 - Stuck on checking merge conflicts #9667

Closed
2 of 7 tasks
marcsiq opened this issue Jan 9, 2020 · 6 comments · Fixed by #9790
Closed
2 of 7 tasks

1.11.rc1 - Stuck on checking merge conflicts #9667

marcsiq opened this issue Jan 9, 2020 · 6 comments · Fixed by #9790
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug
Milestone

Comments

@marcsiq
Copy link

marcsiq commented Jan 9, 2020

  • Gitea version (or commit ref): 1.11.rc1
  • Git version:
  • Operating system: ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I didn't know where to post this one, but I did update my gitea to 1.11-rc1 and since then my PRs get stucked in "Checking for merge conflicts, try again in a few moments" after merging in the main branch. I did roll back to 1.10.2 and it seems to work well on that one.

@zeripath
Copy link
Contributor

zeripath commented Jan 9, 2020

@Marcsiq2 rolling back to 1.10.2 doesn't necessary mean that there was a problem on 1.11 - depending on how you rolled back. The worklist could have just taken that long to work through.

We need some log information to work out what is going wrong - if anything.

There were three major changes to the PR checking:

#9282, #9302 and #9501

#9282 might be the cause of your apparent problem as one of the more hidden changes here was to remove a bug whereby PRs would only ever be checked once.

That means that there's potentially lots more PR checking to do - although the queue is uniqued by PRID - possibly we're doing too much for example if the status check fails then the status will remain in checking.

We need logs. Log trace would have told us what the pull request tester was doing here.

For future reference this configuration should give us TRACE level logs for the pull service:

[log]
MODE=...,traceconsole ; Add the traceconsole logger to your current log modes
...

[log.traceconsole]
MODE=console
LEVEL=trace
EXPRESSION=services/pull

@marcsiq
Copy link
Author

marcsiq commented Jan 10, 2020

Thank you very much for your detailed help! I'll try that.

@sapk sapk modified the milestone: 1.11.0 Jan 15, 2020
@sapk sapk added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Jan 15, 2020
@zeripath
Copy link
Contributor

The console log is emitted on stdout. You can change the mode to file and set a FILE_NAME if you can't use the console.

On 1.10 the EXPRESSION should be models/pull

If you're getting the problem on 1.10 it is likely that you're facing the issue that there is just one worker running the pull request task and it's just busy.

@zeripath zeripath removed the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Jan 15, 2020
@marcsiq
Copy link
Author

marcsiq commented Jan 15, 2020

giteapulls.txt

Find there logs for both 1.10 and 1.11rc1

1.10 worked fine after a restart, while 1.11 is stuck in "checking merge conflict" and nothing else appears on the log.

@marcsiq
Copy link
Author

marcsiq commented Jan 15, 2020

giteapulls2.txt

And all this appears and the "checking..." disappears after restarting gitea.

@zeripath
Copy link
Contributor

I think I've found the cause.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants