Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing unlock in uniquequeue #9790

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Fix missing unlock in uniquequeue #9790

merged 2 commits into from
Jan 15, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 15, 2020 •
edited
Loading

Fixes a missing unlock in uniquequeue that will cause a deadlock.

Fix #9667
Likely Fixes #9759

@zeripath zeripath added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself backport/v1.11 labels Jan 15, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 15, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2020
@lafriks lafriks merged commit e7923c4 into go-gitea:master Jan 15, 2020
@lafriks lafriks added the backport/done All backports for this PR have been created label Jan 15, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@70508b0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9790   +/-   ##
=========================================
  Coverage          ?   42.17%           
=========================================
  Files             ?      603           
  Lines             ?    78837           
  Branches          ?        0           
=========================================
  Hits              ?    33251           
  Misses            ?    41512           
  Partials          ?     4074
Impacted Files Coverage Δ
routers/routes/routes.go 86.51% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70508b0...6dad1e4. Read the comment docs.

@zeripath zeripath deleted the fix-deadlock-unique-table branch January 15, 2020 22:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidsvantesson davidsvantesson davidsvantesson approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

View PR in UI always returns 500 1.11.rc1 - Stuck on checking merge conflicts
5 participants
@zeripath @codecov-io @davidsvantesson @lafriks @GiteaBot