Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send tag create and push webhook when release created on UI (#8671) #9702

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Send tag create and push webhook when release created on UI (#8671) #9702

merged 1 commit into from
Jan 13, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 11, 2020

Backport #8671

@lafriks lafriks added this to the 1.10.3 milestone Jan 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 11, 2020
@sapk
Copy link
Member

sapk commented Jan 12, 2020

This seems to need functions in notification module that are not present in v1.10.

@lafriks
Copy link
Member Author

lafriks commented Jan 12, 2020

Yes, I'm rewriting it now

@lafriks lafriks force-pushed the backport/fix/tag_webhook branch 2 times, most recently from 4cf464c to 3e26f96 Compare January 13, 2020 06:29
@blueworrybear @lafriks
Send tag create and push webhook when release created on UI (go-gitea…
ed4ffe1 
…#8671)

* 'update'

* Send push tag event when release created

* send tag create event while release created in UI

* update to go v1.13

* fix gofmt error

* update go-gitea#8671 move release tag created hook to modules/notification/webhook due to go-gitea#8802 refactoring

* use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag

* move tag notification to correct place
@lafriks
Copy link
Member Author

lafriks commented Jan 13, 2020

Ok, refactored to webhooks how they were in 1.10 :)

@zeripath zeripath merged commit b67a023 into go-gitea:release/v1.10 Jan 13, 2020
@lafriks lafriks deleted the backport/fix/tag_webhook branch January 13, 2020 07:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@adelowo adelowo adelowo approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.3
Development

Successfully merging this pull request may close these issues.
8 participants
@lafriks @sapk @lunny @adelowo @6543 @zeripath @GiteaBot @blueworrybear