Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch protection: Require branches to be up to date before merging #9786

Closed
davidsvantesson opened this issue Jan 15, 2020 · 4 comments · Fixed by #11012
Closed

Branch protection: Require branches to be up to date before merging #9786

davidsvantesson opened this issue Jan 15, 2020 · 4 comments · Fixed by #11012
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@davidsvantesson
Copy link
Contributor

Add a branch protection option allowing strict status checks. PR shall not be possible to merge unless it is up to date (divergence behind target is zero).

@guillep2k
Copy link
Member

Sounds like this should be added to #8659 ... should I?

@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 16, 2020
@zeripath
Copy link
Contributor

Yeah add it

@6543
Copy link
Member

6543 commented Jan 17, 2020

hint: use function pull_service.GetDiverging(pull) added via #9784

@stale
Copy link

stale bot commented Mar 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 17, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 17, 2020
@stale stale bot removed the issue/stale label Mar 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants