Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality that is useful for Gitea's administrative workflow #8659

Open
guillep2k opened this issue Oct 24, 2019 · 12 comments
Open

Functionality that is useful for Gitea's administrative workflow #8659

guillep2k opened this issue Oct 24, 2019 · 12 comments
Labels

Comments

@guillep2k
Copy link
Member

@guillep2k guillep2k commented Oct 24, 2019

As the move to gitea.com is getting closer, I was thinking about those useful features that we as maintainers will miss after we move; I mean those specifically needed for the workflow of maintaining Gitea itself.

The idea is to make a list of those features we consider the most useful, so contributors can have specific goals to help with.

As a maintainer I'm not familiar with many of the tasks involved in the administration of Gitea, so I'll start with my short list to open the discussion.

NOTE: in this list I'm collecting ideas from the comments below

  • An Update branch button #9750 (#9784).
  • Select specific commits when reviewing code.
  • Expand/collapse source files while reviewing code #8579 (#8924)
  • The ability to expand code beyond the given context when comparing/reviewing (#8924).
  • Mark files as seen while reviewing code.
  • Close/reopen issues from PR comments (#8866)
  • Make changelog tool use Gitea.
  • Show on Pull request list page:
    • Number of required approvals still remaining, or the number approvals obtained (#8762) (#9274).
    • Has the PR passed CI.
    • Is it blocked by another issue/PR.
    • Does it produce conflicts. (Much harder, probably)
  • Commiteable code change suggestions (beware non-utf8 encodings!); related: #9388.
  • Require branches to be up to date before merging #9786.

Extra points

  • Always display the members page for public organizations; see #7501
@davidsvantesson

This comment has been minimized.

Copy link
Contributor

@davidsvantesson davidsvantesson commented Oct 24, 2019

  • A count of approvals in the PR page.

You already have that?
This Pull Request doesn't have enough approvals yet. 1 of 2 approvals granted.
Or do you mean the list of reviewers in the right sidebar? That I think would be useful to have.

@zeripath

This comment has been minimized.

Copy link
Contributor

@zeripath zeripath commented Oct 24, 2019

He means on the list of PRs page. In GitHub we use labels to set this but Gitea has that built in

@lunny

This comment has been minimized.

Copy link
Member

@lunny lunny commented Oct 24, 2019

It could be `Show approvals counts on Pull request list page"

@lunny lunny added the kind/proposal label Oct 24, 2019
@guillep2k

This comment has been minimized.

Copy link
Member Author

@guillep2k guillep2k commented Oct 25, 2019

For this one:

  • Does it produce conflicts.

I think a small client-side button to check could be used? I mean, it could show something like that, when pressed, a request is sent to the server and the button is changed into ✔️ or .

@blueworrybear

This comment has been minimized.

Copy link
Contributor

@blueworrybear blueworrybear commented Oct 29, 2019

It's better to add Expand Up and Expand Down button too IMO. 🤔

@guillep2k

This comment has been minimized.

Copy link
Member Author

@guillep2k guillep2k commented Oct 30, 2019

It's better to add Expand Up and Expand Down button too IMO. 🤔

Sorry, are you referring to the "does it produce conflicts" option?

@jolheiser

This comment has been minimized.

Copy link
Member

@jolheiser jolheiser commented Oct 30, 2019

Suggestions! 😢
(Meaning the ones you can commit)

@jamesorlakin

This comment has been minimized.

Copy link

@jamesorlakin jamesorlakin commented Oct 30, 2019

Number of required approvals still remaining, or the number approvals obtained.

I came across this issue seeing if this exact feature was possibly in progress already, or whether it was worth me having an attempt. I've never touched Go before (I'm a full-stack TypeScript dev) but love the work put into Gitea!

After some playing about for over an hour I have this:
image

The first number being the number of granted approvals, and the second the required ones. Let me know if you would be interested in a PR 👍 .

@lafriks

This comment has been minimized.

Copy link
Member

@lafriks lafriks commented Oct 30, 2019

@jamesorlakin sure send PR ;)

@jamesorlakin

This comment has been minimized.

Copy link

@jamesorlakin jamesorlakin commented Oct 30, 2019

@lafriks Sure thing, I'll try to get it out tomorrow

@blueworrybear

This comment has been minimized.

Copy link
Contributor

@blueworrybear blueworrybear commented Oct 31, 2019

@guillep2k
I mean the code folding/unfolding. Here is an example:
expand

@guillep2k

This comment has been minimized.

Copy link
Member Author

@guillep2k guillep2k commented Oct 31, 2019

@guillep2k
I mean the code folding/unfolding. Here is an example:

Oh, of course!

blueworrybear added a commit to blueworrybear/gitea that referenced this issue Oct 31, 2019
blueworrybear added a commit to blueworrybear/gitea that referenced this issue Nov 10, 2019
lunny added a commit that referenced this issue Nov 15, 2019
…#8924)

* update #8659 fold/unfold code diffs

* add fold button style

* update #8659 implement expand up/down codes (blob excerpt)

* fix golint errors

* fix expand direction

* remove debug message

* update css style for blob exceprt

* fix typo in comment

* update style sheet with less

* update expect diff (add SectionInfo)

* update #8942 accept suggested change (fix typo)

* close reader and check file type before get tail section

* adjust button position and check file type before insert fold button

* move index js to web_src

* merge index.js with master

* generate index.js

* update js coding style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.