Functionality that is useful for Gitea's administrative workflow

[guillep2k]

As the move to gitea.com is getting closer, I was thinking about those useful features that we as maintainers will miss after we move; I mean those specifically needed for the workflow of maintaining Gitea itself.

The idea is to make a list of those features we consider the most useful, so contributors can have specific goals to help with.

As a maintainer I'm not familiar with many of the tasks involved in the administration of Gitea, so I'll start with my short list to open the discussion.

NOTE: in this list I'm collecting ideas from the comments below

• An Update branch button "Update Branch" button on PR #9750 (Add "Update Branch" button to Pull Requests #9784).
• Expand/collapse source files while reviewing code Feature Request: collapse File-Diff on PR view  #8579 (Expand/Collapse Files and Blob Excerpt while Reviewing/Comparing code #8924).
• The ability to expand code beyond the given context when comparing/reviewing (Expand/Collapse Files and Blob Excerpt while Reviewing/Comparing code #8924).
• Mark files as seen while reviewing code. (Support "Viewed" option in Pull Requests #11730) -> (Allow to mark files in a PR as viewed #19007)
• Close/reopen issues from PR comments (Close/reopen issues by keywords in titles and comments #8866).
• Make changelog tool use Gitea (gitea/changelog#19).
• Allow edits from maintainer (Add "Allow edits from maintainer" feature #18002)
• Require branches to be up to date before merging Branch protection: Require branches to be up to date before merging #9786 (Prevent merge of outdated PRs on protected branches #11012).
• Show on Pull request list page:
  • Number of required approvals still remaining, or the number approvals obtained (Show approvals on the PR listing page #8762) (Show review labels in the pull request lists #9274) (Add Approval Counts to pulls list #10238).
  • Has the PR passed CI.
  • Does it contain conflicts (Show if a PR has conflicting files on the PR lists #10130).
  • Is it blocked by another issue/PR. (Show depending and blocked PRs in the PR list #29117)
• Commiteable code change suggestions (Add Button to apply diff comments to PRs #9388)
• Multi line review comments (Multi line review comments like github #12640, add multi-line comment support in api #25523)
• Select specific commits when reviewing code. Add commits dropdown in PR files view and allow commit by commit review #25528
• Always display the members page for public organizations; see Display org members if org is public #7501

[davidsvantesson]

• A count of approvals in the PR page.

You already have that?
This Pull Request doesn't have enough approvals yet. 1 of 2 approvals granted.
Or do you mean the list of reviewers in the right sidebar? That I think would be useful to have.

[zeripath]

He means on the list of PRs page. In GitHub we use labels to set this but Gitea has that built in

[lunny]

It could be `Show approvals counts on Pull request list page"

[guillep2k]

For this one:

• Does it produce conflicts.

I think a small client-side button to check could be used? I mean, it could show something like ❔ that, when pressed, a request is sent to the server and the button is changed into ✔️ or ❌.

[blueworrybear]

It's better to add Expand Up and Expand Down button too IMO. 🤔

[guillep2k]

It's better to add Expand Up and Expand Down button too IMO. 🤔

Sorry, are you referring to the "does it produce conflicts" option?

[jolheiser]

Suggestions! 😢
(Meaning the ones you can commit)

[jamesorlakin]

Number of required approvals still remaining, or the number approvals obtained.

I came across this issue seeing if this exact feature was possibly in progress already, or whether it was worth me having an attempt. I've never touched Go before (I'm a full-stack TypeScript dev) but love the work put into Gitea!

After some playing about for over an hour I have this:

The first number being the number of granted approvals, and the second the required ones. Let me know if you would be interested in a PR 👍 .

[lafriks]

@jamesorlakin sure send PR ;)

[jamesorlakin]

@lafriks Sure thing, I'll try to get it out tomorrow

[blueworrybear]

@guillep2k
I mean the code folding/unfolding. Here is an example:

[guillep2k]

@guillep2k
I mean the code folding/unfolding. Here is an example:

Oh, of course!

[jolheiser]

Changelog tool now supports Gitea. 🎉

[jamesorlakin]

• Does it produce conflicts. (Much harder, probably)

Would this just mean making use of the ConflictedFiles array on the pull model? If so, I whipped up this in a few lines by tweaking the template:

[guillep2k]

Would this just mean making use of the ConflictedFiles array on the pull model? If so, I whipped up this in a few lines by tweaking the template:

@jamesorlakin Care to submit a PR? 😁

[lunny]

It seems it's easier to diaplsy files conflicted.

[zeripath]

This is on the PRs list page not on a particular pr page.

[6543]

@guillep2k you can add #11012

[6543]

@guillep2k you can check Require branches to be up to date before merging by the way :)

[6543]

wow now it's near of complete 🎉

[6543]

Select specific commits when reviewing code.

can this be specified bit more please?

[delvh]

Also, what I noticed is missing:

• multiline comments
• comments on commits as well as in PRs