-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues/pulls dependencies problems #9842
Conversation
89057ab
to
7da97e7
Compare
I also found more problems about issue dependencies and will fix them on next PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need make generate-swagger
beside that ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make generate-swagger + rename filed + clarify description
7da97e7
to
f1e36b1
Compare
@silverwind @6543 done. |
f1e36b1
to
a7866b0
Compare
@@ -428,6 +428,7 @@ | |||
<input type="hidden" id="repolink" value="{{$.RepoRelPath}}"> | |||
<input type="hidden" id="repoId" value="{{.Repository.ID}}"> | |||
<input type="hidden" id="crossRepoSearch" value="{{.AllowCrossRepositoryDependencies}}"> | |||
<input type="hidden" id="type" value="{{.IssueType}}"> | |||
<!-- I know, there is probably a better way to do this --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not relevant for this PR, but we should get rid of this comment or at least hide it from the rendered output:
<!-- I know, there is probably a better way to do this --> | |
{{/* I know, there is probably a better way to do this */}} |
Codecov Report
@@ Coverage Diff @@
## master #9842 +/- ##
==========================================
- Coverage 42.31% 42.31% -0.01%
==========================================
Files 604 604
Lines 79137 79155 +18
==========================================
+ Hits 33490 33493 +3
- Misses 41521 41533 +12
- Partials 4126 4129 +3
Continue to review full report at Codecov.
|
* Fix issues/pulls dependencies problems * fix swagger and api param name * fix js
Fix #6039