Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the stdout to errors on the temp repo pushing #9871

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

zeripath
Copy link
Contributor

No description provided.

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Jan 19, 2020
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #9871 into master will decrease coverage by 0.06%.
The diff coverage is 2.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9871      +/-   ##
==========================================
- Coverage   42.32%   42.25%   -0.07%     
==========================================
  Files         604      605       +1     
  Lines       79171    79248      +77     
==========================================
- Hits        33510    33488      -22     
- Misses      41533    41630      +97     
- Partials     4128     4130       +2
Impacted Files Coverage Δ
models/migrations/migrations.go 1.3% <ø> (ø) ⬆️
models/migrations/v124.go 0% <0%> (ø)
routers/user/auth.go 11.44% <0%> (-0.59%) ⬇️
modules/markup/sanitizer.go 85.71% <100%> (ø) ⬆️
models/login_source.go 25.63% <7.14%> (-0.13%) ⬇️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
modules/queue/workerpool.go 41.2% <0%> (-3.01%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3160908...4c361e3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah here it is

@lunny lunny merged commit 54c2854 into go-gitea:master Jan 20, 2020
@zeripath zeripath deleted the better-error-temp-repo branch January 20, 2020 07:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants