-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add css extraction and minification to webpack #9944
Conversation
8cac269
to
a2c414c
Compare
Codecov Report
@@ Coverage Diff @@
## master #9944 +/- ##
=========================================
Coverage ? 42.24%
=========================================
Files ? 610
Lines ? 80295
Branches ? 0
=========================================
Hits ? 33919
Misses ? 42214
Partials ? 4162
Continue to review full report at Codecov.
|
In case anyone's wondering: webpack build time is pretty much unchanged. |
This changes the CSS output of webpack to output to the public/css directory instead of inling CSS in JS. This enables CSS minification and autoprefixer based on browserslist which would otherwise not be possible. The result of this change is two new output files currently: - public/css/swagger.css - public/css/gitgraph.css
881418e
to
c43dec4
Compare
Rebased and added some trailing commas in |
This changes the CSS output of webpack to output to the public/css directory instead of inling CSS in JS. This enables CSS minification and autoprefixer based on browserslist which would otherwise not be possible.
The result of this change is two new output files currently: