API: support /users/:username/repos #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
suggested changes
Feb 25, 2017
routers/api/v1/api.go
Outdated
| @@ -284,6 +285,9 @@ func RegisterRoutes(m *macaron.Macaron) { | |||
| Delete(user.DeletePublicKey) | |||
| }) | |||
|
|
|||
| m.Combo("/repos", reqToken()).Get(user.ListMyRepos). | |||
There was a problem hiding this comment.
reqToken() isn't required here; it is already included on line 301.
|
One small tweak, otherwise LGTM |
tboerger
added
the
lgtm/need 1
ethantkoenig
approved these changes
Feb 26, 2017
appleboy
suggested changes
Feb 26, 2017
routers/api/v1/user/repo.go
Outdated
|
|
||
| import ( | ||
| api "code.gitea.io/sdk/gitea" | ||
|
|
routers/api/v1/user/repo.go
Outdated
| // listUserRepos - List the repositories owned by the given user. | ||
| func listUserRepos(ctx *context.APIContext, u *models.User) { | ||
| userID := u.ID | ||
| showPrivateRepos := ctx.User.ID == userID && ctx.IsSigned |
There was a problem hiding this comment.
(ctx.User.ID == userID || ctx.User.IsAdmin) && ctx.IsSigned
appleboy
approved these changes
Feb 26, 2017
|
LGTM |
tboerger
added
lgtm/done
clean up fix arguments remove repeated token give admins listing rights
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for half of: #494. I'm not 100% sure about the movement of functions and files and defer to you but I thought this grouping made sense.