Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh codemirror on show pull comment tab (#11100) #11122

Merged
merged 1 commit into from Apr 18, 2020
Merged

Refresh codemirror on show pull comment tab (#11100) #11122

merged 1 commit into from Apr 18, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 18, 2020 •
edited

Backport #11100

Fix #10975

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath @jolheiser
@techknowlogick @guillep2k
Refresh codemirror on show pull comment tab (go-gitea#11100)
a8f0e0f 
Fix go-gitea#10975

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
@zeripath zeripath added this to the 1.11.5 milestone Apr 18, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2020
@guillep2k
Copy link
Member

guillep2k commented Apr 18, 2020 •
edited

Is this a backport or an 1.11.5-only fix?
🤦‍♂️
Oh, don't mind me

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit d9875ff into go-gitea:release/v1.11 Apr 18, 2020
@zeripath zeripath deleted the backport-11100 branch April 18, 2020 19:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zeripath @guillep2k @jolheiser @GiteaBot