Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that relative paths in edit preview work #11143

Merged
merged 5 commits into from Apr 20, 2020

Conversation

zeripath
Copy link
Contributor

Fix #10131

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#10131

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.12.0 milestone Apr 19, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 19, 2020
web_src/js/index.js Outdated Show resolved Hide resolved
@silverwind
Copy link
Member

Needs som linter fixes (semicolons, const).

web_src/js/index.js Outdated Show resolved Hide resolved
@zeripath
Copy link
Contributor Author

So that linter has actually done the impossible: it's made dealing with js even more bloody annoying.

web_src/js/index.js Outdated Show resolved Hide resolved
web_src/js/index.js Outdated Show resolved Hide resolved
web_src/js/index.js Outdated Show resolved Hide resolved
@silverwind
Copy link
Member

silverwind commented Apr 20, 2020

@zeripath you should try an editor plugin for eslint, it's very fast. Most errors can also be autofixed via npx eslint --fix file.

web_src/js/index.js Outdated Show resolved Hide resolved
Co-Authored-By: Lauris BH <lauris@nix.lv>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2020
@lafriks lafriks merged commit 067eff8 into go-gitea:master Apr 20, 2020
@zeripath zeripath deleted the fix-10131-relative-paths-in-preview branch April 20, 2020 10:56
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Fix go-gitea#10131

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative links broken in preview mode
4 participants