When using API CreateRelease set created_unix to the tag commit time

[jasder]

When creating a release with api, the release time of the version is wrong(is actually the user's update time)

Ex:

[6543]

pleace "update" this branch

[guillep2k]

This looks good to me, but the current behavior looks kind of fishy... almost intended. Can this be considered a matter of preference? This PR will not affect just the API.

[6543]

same thought - but think this behaviour more intuetive - to controle it via an option would probably be the best ...

[6543]

@jasder change this pull so it can be controled via option

[lunny]

A release is based on a tag, but should release created time be the same as the tag time? Since tag time has been saved on git, so it's unnecessary to save it again in the database.

[jasder]

@lunny But release's the return created time is based on release, and rend directly from the database.

[guillep2k]

OK, I think this makes sense.

[codecov-io]

Codecov Report

Merging #11218 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11218      +/-   ##
==========================================
+ Coverage   43.29%   43.30%   +0.01%     
==========================================
  Files         605      605              
  Lines       86246    86246              
==========================================
+ Hits        37340    37351      +11     
+ Misses      44305    44301       -4     
+ Partials     4601     4594       -7     

Impacted Files	Coverage Δ
services/release/release.go	27.04% <100.00%> (ø)
services/pull/temp_repo.go	31.62% <0.00%> (-2.57%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.93%)	⬇️
services/pull/check.go	55.48% <0.00%> (-1.22%)	⬇️
modules/queue/workerpool.go	56.93% <0.00%> (-1.07%)	⬇️
models/issue.go	52.10% <0.00%> (+0.46%)	⬆️
modules/notification/webhook/webhook.go	40.20% <0.00%> (+0.58%)	⬆️
services/pull/pull.go	34.54% <0.00%> (+1.14%)	⬆️
services/pull/patch.go	67.83% <0.00%> (+2.09%)	⬆️
modules/process/manager.go	78.31% <0.00%> (+3.61%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e7361...131f06d. Read the comment docs.

[richmahn]

@lunny @jasder I am having problems due to this little change. Even if you update the content of a release (the message such as make a change to the changelog in the content), the created_unix time of the release gets updated again! It isn't when the tag was created any more.

[richmahn]

So somewhat related, in that this shouldn't be set when a tag is already set (before it didn't matter since it was going by the commit date that the tag pointed to): #12341. Please make backport to 1.12 if possible.