Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove padding/border-radius on image diffs #12346

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Remove padding/border-radius on image diffs #12346

merged 2 commits into from
Jul 28, 2020

Conversation

silverwind
Copy link
Member

Before:

image

After:

image

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jul 28, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jul 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 28, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit cd7f1fd into go-gitea:master Jul 28, 2020
@silverwind silverwind deleted the imgdiff branch July 28, 2020 16:36
silverwind added a commit to silverwind/gitea that referenced this pull request Jul 30, 2020
@silverwind
Actually fix image diff padding/border
0e1bd1e 
go-gitea#12346 was using the wrong
selector which affected only the single image view. Use the correct
selector for image diffs. Removal of border-radius is still worth to
keep to override the global 3px on <img>.
@silverwind silverwind mentioned this pull request Jul 30, 2020
Merged
techknowlogick pushed a commit that referenced this pull request Aug 6, 2020
@silverwind @lafriks
Actually fix image diff padding/border (#12381)
0dfbef5 
#12346 was using the wrong
selector which affected only the single image view. Use the correct
selector for image diffs. Removal of border-radius is still worth to
keep to override the global 3px on <img>.

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @zeripath @mrsdizzie @GiteaBot