Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE on commenting on lines with invalidated comments (with migration) #12549

Merged
merged 4 commits into from Aug 21, 2020
Merged

Prevent NPE on commenting on lines with invalidated comments (with migration) #12549

merged 4 commits into from Aug 21, 2020

Commits on Aug 20, 2020

  1. Prevent NPE on commenting on lines with invalidated comments 

    Only check for a review if we are replying to a previous review.

Prevent the NPE in go-gitea#12239 by assuming that a comment without a Review is
non-pending.

Fix go-gitea#12239

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Aug 20, 2020
    Copy the full SHA
    309fd94 View commit details
    Browse the repository at this point in the history

  2. Add hack around to show the broken comments 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Aug 20, 2020
    Copy the full SHA
    80ab986 View commit details
    Browse the repository at this point in the history

  3. Add migration and remove template hacks 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Aug 20, 2020
    Copy the full SHA
    16fd2c3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-12239-review-page-500-with-migration

    @zeripath
    zeripath committed Aug 20, 2020
    Copy the full SHA
    b5e9c48 View commit details
    Browse the repository at this point in the history