Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Inform user what meaning hourglass on reviews has #12713

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 4, 2020

as title - see screenshot

Bildschirmfoto zu 2020-09-04 17-08-38

@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 4, 2020
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #12713 into master will increase coverage by 0.02%.
The diff coverage is 11.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12713      +/-   ##
==========================================
+ Coverage   43.29%   43.32%   +0.02%     
==========================================
  Files         646      646              
  Lines       71592    71567      -25     
==========================================
+ Hits        30993    31003      +10     
+ Misses      35583    35547      -36     
- Partials     5016     5017       +1     
Impacted Files Coverage Δ
models/migrations/migrations.go 4.66% <ø> (ø)
models/migrations/v148.go 0.00% <0.00%> (ø)
models/user.go 53.56% <ø> (-0.20%) ⬇️
modules/graceful/server.go 47.00% <0.00%> (-0.41%) ⬇️
modules/highlight/highlight.go 24.69% <0.00%> (ø)
modules/migrations/gitlab.go 1.04% <0.00%> (-0.10%) ⬇️
modules/public/public.go 56.16% <0.00%> (ø)
modules/session/virtual.go 60.20% <0.00%> (ø)
routers/repo/issue.go 37.49% <0.00%> (-0.06%) ⬇️
modules/migrations/base/downloader.go 17.64% <5.12%> (-5.72%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e710a34...8d070c4. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Sep 4, 2020

CI: Remote visit addressed rate limitation. :(

@techknowlogick techknowlogick merged commit ca81b65 into go-gitea:master Sep 4, 2020
@6543 6543 deleted the ui-give-review-sandglas-meaning branch September 4, 2020 16:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants