Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return a list from GetCommitsFromIDs #12981

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Always return a list from GetCommitsFromIDs #12981

merged 2 commits into from
Sep 29, 2020

Commits on Sep 29, 2020

  1. Always return a list from GetCommitsFromIDs 

    `GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where
it expects that `c.Commits` is not nil.

This potentially nil set causes a NPE in in go-gitea#12953

Fix go-gitea#12953

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    13fe079 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-12953-prevent-NPE-in-issue_comments

    @zeripath
    zeripath committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    91bc4c8 View commit details
    Browse the repository at this point in the history