Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsErrNotValidReviewRequest should check if ErrNotValidReviewRequest not ErrReviewNotExist #13187

Merged
merged 1 commit into from Oct 17, 2020
Merged

IsErrNotValidReviewRequest should check if ErrNotValidReviewRequest not ErrReviewNotExist #13187

merged 1 commit into from Oct 17, 2020

Conversation

a1012112796
Copy link
Member

I'm sorry for my fault.

@a1012112796
fix a small nit
2ec3423 
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 17, 2020
@lunny lunny added the type/bug label Oct 17, 2020
@lunny
Copy link
Member

lunny commented Oct 17, 2020

@a1012112796 Have you sent a PR to master?

@a1012112796
Copy link
Member Author

@a1012112796 Have you sent a PR to master?

I has changed it in #11355, because it's not a big problem, So I think it's not necessary to send another pr to do it. Thanks.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2020
@zeripath
Copy link
Contributor

@a1012112796 Have you sent a PR to master?

I has changed it in #11355, because it's not a big problem, So I think it's not necessary to send another pr to do it. Thanks.

Is #11355 ready to review then?

I would also adjust the leading comment in #11355 to say that it contains this PR.

@zeripath zeripath added this to the 1.13.0 milestone Oct 17, 2020
@zeripath zeripath changed the title fix a small nit IsErrNotValidReviewRequest should check if ErrNotValidReviewRequest not ErrReviewNotExist Oct 17, 2020
@zeripath zeripath mentioned this pull request Oct 17, 2020
Merged
@lunny lunny merged commit 1ba4a7e into go-gitea:release/v1.13 Oct 17, 2020
@a1012112796 a1012112796 deleted the fix_nit branch October 17, 2020 16:30
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 10, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@a1012112796 @lunny @zeripath @GiteaBot @6543