Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heatmap colors more distinct #13533

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 12, 2020

Screen Shot 2020-11-12 at 20 55 57

Screen Shot 2020-11-12 at 20 55 50

The second shade falls out of the scheme of 20% increases because it was too hard to see at just 20% opacity but it seems still distinct enough to me from the third color.

Random data generator code
    this.values = new Array(400).fill().map((_, i) => {
      const date = new Date(new Date().setDate(new Date().getDate() - i));
      let count = Math.round(Math.random() * 100);
      if (count % 3 === 0) count = 0;
      return {date, count};
    });

Fixes: #13529

@silverwind silverwind mentioned this pull request Nov 12, 2020
6 tasks
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label Nov 12, 2020
@jolheiser jolheiser added this to the 1.14.0 milestone Nov 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 12, 2020
@bagasme
Copy link
Contributor

bagasme commented Nov 13, 2020

@silverwind not so much difference between second and third shade (on default scheme)

@silverwind
Copy link
Member Author

Last I tested, there was barely any difference between grey background and 20% opacity primary color, at least on my screen. Will check again later.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

applied your patch @silverwind
maybe it's just me but I also don't think the distinction between certain levels is perfectly visible 🙈 .
it is a laptop screen but it used to be a little more distinct (before the switch to a defined colour palette recently).
image
image

@silverwind
Copy link
Member Author

silverwind commented Nov 13, 2020

Yes, at least level 2 and 3 still need more distinction, don't land this yet.

@silverwind
Copy link
Member Author

Another variation pushed that uses opaque colors and goes a bit more into the darker shades, how does that look to you two?

image

image

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

Another variation pushed that uses opaque colors and goes a bit more into the darker shades, how does that look to you two?

image image

lemme check 🚀

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

image
image
Tried it.
Looks fine 💯
Maybe the first level could have a little more opacity (so as not to be as prominent, as it's the least significant one)?

@silverwind
Copy link
Member Author

Ok, made the grey color less opaque (70% as before).

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

Ok, made the grey color less opaque (70% as before).

thanks, building...

so this imo looks better now, I think the levels are a liitle easier to distinguish.
image
image

edit: added screenshots

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 3cd00c3 into go-gitea:master Nov 13, 2020
@silverwind silverwind deleted the heatcolors branch November 13, 2020 19:50
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heatmap Color Shade
8 participants