Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mount but not register for chi routes #13555

Merged
merged 8 commits into from Nov 16, 2020
Merged

Use mount but not register for chi routes #13555

merged 8 commits into from Nov 16, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 14, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 14, 2020
@lafriks
Copy link
Member

lafriks commented Nov 14, 2020

Tests still failing

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 14, 2020
6543
6543 reviewed Nov 14, 2020
View reviewed changes
cmd/web.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 14, 2020
6543
6543 requested changes Nov 14, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... sorry

@6543 6543 added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2020
lafriks
lafriks reviewed Nov 15, 2020
View reviewed changes
routers/routes/chi.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #13555 (3d337e6) into master (efcba9b) will decrease coverage by 0.03%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13555      +/-   ##
==========================================
- Coverage   42.25%   42.21%   -0.04%     
==========================================
  Files         696      696              
  Lines       76523    76529       +6     
==========================================
- Hits        32337    32310      -27     
- Misses      38890    38919      +29     
- Partials     5296     5300       +4
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
routers/install.go 0.00% <0.00%> (ø)
routers/routes/chi.go 40.66% <77.77%> (+1.62%) ⬆️
services/pull/check.go 48.90% <0.00%> (-6.57%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/gitdiff/gitdiff.go 67.71% <0.00%> (-1.97%) ⬇️
modules/git/command.go 88.34% <0.00%> (-1.95%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
modules/queue/workerpool.go 57.95% <0.00%> (-0.82%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcba9b...3d337e6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2020
@lunny lunny merged commit 586bfb9 into go-gitea:master Nov 16, 2020
@lunny lunny deleted the lunny/chi_mount branch November 16, 2020 07:33
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @lafriks @codecov-io @silverwind @6543 @GiteaBot