Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set git-core paths in snap #13711

Merged
merged 2 commits into from Nov 30, 2020
Merged

Set git-core paths in snap #13711

merged 2 commits into from Nov 30, 2020

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Nov 26, 2020

This PR sets the paths to find git-core in the snap packaging. It fixes the issue to migrate repository from e.g. Github:

Migrate repository from https://github.com/artivis/some-repo.git failed: Clone: exit status 128 - warning: templates not found /usr/share/git-core/templates
fatal: Unable to find remote helper for 'https'

Successfully tested locally.

Closes #12388

@artivis
set git-core paths in snap
4906ce5 
Signed-off-by: artivis <deray.jeremie@gmail.com>
@artivis
Copy link
Contributor Author

artivis commented Nov 26, 2020

@popey FYI.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2020
@lunny lunny added the topic/distribution This PR changes something about the packaging of Gitea label Nov 26, 2020
@silverwind
Copy link
Member

Are these paths guaranteed to exit?

@artivis
Copy link
Contributor Author

artivis commented Nov 27, 2020

Are these paths guaranteed to exit?

Yes, /usr/{lib,share}/git-core are the default paths and $SNAP is snapcraft root prefix path. Note that the default paths (without the prefix) do not exist hence the issue.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2020
@techknowlogick techknowlogick merged commit 870fd53 into go-gitea:master Nov 30, 2020
@artivis artivis deleted the fix/snap-git-core branch December 1, 2020 00:36
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Dec 2, 2020
@artivis @techknowlogick
set git-core paths in snap (go-gitea#13711)
f37533c 
Signed-off-by: artivis <deray.jeremie@gmail.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Dec 2, 2020
techknowlogick added a commit that referenced this pull request Dec 2, 2020
@techknowlogick @artivis
set git-core paths in snap (#13711) (#13781)
f677ed6 
Signed-off-by: artivis <deray.jeremie@gmail.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Snap-package broken MySQL TLS, HTTPS repo-migration
6 participants
@artivis @silverwind @techknowlogick @lafriks @lunny @GiteaBot