Trim the branch prefix from action.GetBranch #13981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-gitea#13882 has revealed that the refname of an action is actually only a refname pattern and necessarily a branch. For examplem pushing to refs/heads/master will result in action with refname refs/heads/master but pushing to master will result in a refname master. The simplest solution to providing a fix here is to trim the prefix therefore this PR proposes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
|
@zeripath Please fix lint :) |
GiteaBot
added
the
lgtm/need 2
a1012112796
reviewed
Dec 14, 2020
Co-authored-by: a1012112796 <1012112796@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #13981 +/- ##
==========================================
- Coverage 42.23% 42.22% -0.02%
==========================================
Files 710 710
Lines 77233 77233
==========================================
- Hits 32623 32614 -9
- Misses 39245 39259 +14
+ Partials 5365 5360 -5
Continue to review full report at Codecov.
|
mrsdizzie
approved these changes
Dec 14, 2020
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Dec 14, 2020
GiteaBot
added
lgtm/done
|
Please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 14, 2020
Backport go-gitea#13981 go-gitea#13882 has revealed that the refname of an action is actually only a refname pattern and necessarily a branch. For examplem pushing to refs/heads/master will result in action with refname refs/heads/master but pushing to master will result in a refname master. The simplest solution to providing a fix here is to trim the prefix therefore this PR proposes this. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: a1012112796 <1012112796@qq.com>
techknowlogick
pushed a commit
that referenced
this pull request
Dec 14, 2020
Backport #13981 #13882 has revealed that the refname of an action is actually only a refname pattern and necessarily a branch. For examplem pushing to refs/heads/master will result in action with refname refs/heads/master but pushing to master will result in a refname master. The simplest solution to providing a fix here is to trim the prefix therefore this PR proposes this. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: a1012112796 <1012112796@qq.com> Co-authored-by: a1012112796 <1012112796@qq.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13882 has revealed that the refname of an action is actually only a
refname pattern and necessarily a branch. For examplem pushing to
refs/heads/master will result in action with refname refs/heads/master
but pushing to master will result in a refname master.
The simplest solution to providing a fix here is to trim the prefix
therefore this PR proposes this.
Fix #13979
Signed-off-by: Andrew Thornton art27@cantab.net