Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HotFix: Hide private partisipation in Orgs #13994

Merged
merged 6 commits into from Dec 16, 2020
Merged

HotFix: Hide private partisipation in Orgs #13994

merged 6 commits into from Dec 16, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 15, 2020

close #13868

@6543 6543 added the modifies/api This PR adds API routes or modifies them label Dec 15, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 15, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #13994 (764da9f) into master (b8c58ed) will decrease coverage by 0.00%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13994      +/-   ##
==========================================
- Coverage   42.23%   42.22%   -0.01%     
==========================================
  Files         710      710              
  Lines       77261    77275      +14     
==========================================
- Hits        32629    32628       -1     
- Misses      39266    39271       +5     
- Partials     5366     5376      +10
Impacted Files Coverage Δ
models/user.go 54.14% <ø> (-0.21%) ⬇️
routers/api/v1/utils/utils.go 58.97% <33.33%> (-7.70%) ⬇️
routers/api/v1/org/org.go 63.15% <87.50%> (+2.04%) ⬆️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
services/mirror/mirror.go 15.78% <0.00%> (-1.11%) ⬇️
modules/queue/workerpool.go 57.95% <0.00%> (-0.82%) ⬇️
services/mailer/mail.go 61.29% <0.00%> (+1.07%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c58ed...764da9f. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 16, 2020
@6543
Copy link
Member Author

6543 commented Dec 16, 2020

🚀

@6543 6543 merged commit 9e456b5 into go-gitea:master Dec 16, 2020
@6543 6543 deleted the api_fix-list-user-orgs branch December 16, 2020 23:39
6543 added a commit to 6543-forks/gitea that referenced this pull request Dec 16, 2020
@6543
HotFix: Hide private partisipation in Orgs (go-gitea#13994)
2ac461b 
* HotFix: Hide private partisipation in Orgs

* refactor & add node to fuc GetOrganizations
@6543 6543 mentioned this pull request Dec 16, 2020
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Dec 16, 2020
@6543
Copy link
Member Author

6543 commented Dec 16, 2020

Backport: #14031

@6543 6543 mentioned this pull request Dec 17, 2020
Merged
6543 added a commit that referenced this pull request Dec 17, 2020
@6543 @zeripath
HotFix: Hide private partisipation in Orgs (#13994) (#14031)
df11075 
* HotFix: Hide private partisipation in Orgs

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
@6543 6543 added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khmarbaise khmarbaise khmarbaise approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

[API] List a user's organizations do not respect privacy settings
5 participants
@6543 @codecov-io @khmarbaise @zeripath @GiteaBot