Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] CombinedStatus and CommitStatus related functions & structs #14026

Merged
merged 21 commits into from
Dec 18, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 16, 2020

as title

  • add limit for pagination on repoGetCombinedStatusByRef
  • fix swagger docs

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 16, 2020
@6543 6543 changed the title RM unused struct [Refactor] CombinedStatus and CommitStatus related functions & structs Dec 16, 2020
@6543 6543 marked this pull request as ready for review December 16, 2020 22:26
@6543 6543 removed the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 16, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 16, 2020
@6543 6543 added type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Dec 16, 2020
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #14026 (d324da9) into master (9e456b5) will decrease coverage by 0.08%.
The diff coverage is 55.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14026      +/-   ##
==========================================
- Coverage   42.20%   42.12%   -0.09%     
==========================================
  Files         710      711       +1     
  Lines       77295    77302       +7     
==========================================
- Hits        32626    32564      -62     
- Misses      39290    39383      +93     
+ Partials     5379     5355      -24     
Impacted Files Coverage Δ
modules/convert/convert.go 74.26% <ø> (-1.44%) ⬇️
routers/api/v1/repo/status.go 49.31% <0.00%> (+5.94%) ⬆️
routers/repo/blame.go 0.00% <0.00%> (ø)
routers/repo/commit.go 29.50% <0.00%> (ø)
services/pull/commit_status.go 4.47% <0.00%> (ø)
modules/convert/status.go 50.00% <50.00%> (ø)
routers/repo/pull.go 31.77% <50.00%> (ø)
models/commit_status.go 62.83% <100.00%> (+0.76%) ⬆️
modules/gitgraph/graph_models.go 84.68% <100.00%> (ø)
routers/repo/view.go 38.11% <100.00%> (+0.64%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e456b5...d324da9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 16, 2020
routers/api/v1/repo/status.go Outdated Show resolved Hide resolved
routers/api/v1/repo/status.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Dec 17, 2020

I know this pull diff is not clear in the first place, just because it refactor a lot ...

But I tryed to split up tasks I did in seperate commits and name them as they do ...

hope this will help reviewing this

modules/structs/status.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Dec 17, 2020

@lunny done - good idear "status" is to general

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2020
@6543 6543 added backport/done All backports for this PR have been created and removed type/enhancement An improvement of existing functionality labels Dec 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2020
@lunny lunny merged commit e483220 into go-gitea:master Dec 18, 2020
@6543 6543 deleted the rm-unused branch December 18, 2020 10:15
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug type/docs This PR mainly updates/creates documentation type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants