Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middlewares sequences #14354

Merged
merged 2 commits into from Jan 16, 2021
Merged

Fix middlewares sequences #14354

merged 2 commits into from Jan 16, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 16, 2021

As title.

@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 16, 2021
@codecov-io
Copy link

codecov-io commented Jan 16, 2021 •
edited

Codecov Report

Merging #14354 (2f4aeb7) into master (0a3c335) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14354   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files         744      744           
  Lines       79681    79681           
=======================================
+ Hits        33349    33350    +1     
+ Misses      40833    40832    -1     
  Partials     5499     5499
Impacted Files Coverage Δ
routers/api/v1/api.go 79.50% <100.00%> (ø)
modules/indexer/stats/db.go 56.00% <0.00%> (-12.00%) ⬇️
modules/git/command.go 87.50% <0.00%> (-1.93%) ⬇️
modules/git/repo_commit_nogogit.go 63.33% <0.00%> (-1.67%) ⬇️
services/pull/pull.go 43.06% <0.00%> (+0.49%) ⬆️
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️
modules/git/utils.go 80.55% <0.00%> (+2.77%) ⬆️
modules/git/repo_base_nogogit.go 72.72% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76fefd8...2f4aeb7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Jan 16, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2021
@6543 6543 merged commit dc66e47 into go-gitea:master Jan 16, 2021
@lunny lunny deleted the lunny/middle_seq branch January 16, 2021 13:20
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
@a1012112796
Merge branch 'master' into imap
560f48a 
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-io @lafriks @6543 @techknowlogick @GiteaBot