Comment - Reference in new issue

[KN4CK3R]

Implemented feature request #14315.

This PR implements the "Reference in new issue" feature from GitHub. Also I added the context menu for inline file comments in the PR conversation tab. (was already added with #14339)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@ca63a9d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14366   +/-   ##
=========================================
  Coverage          ?   41.85%           
=========================================
  Files             ?      744           
  Lines             ?    79746           
  Branches          ?        0           
=========================================
  Hits              ?    33375           
  Misses            ?    40861           
  Partials          ?     5510           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca63a9d...dbcd9ab. Read the comment docs.

[lafriks]

Imho best would be to get comment content like it is already done in quote reply not generate input values. Also there is not much point generate dialog form for each comment, one should be enough in page

[lunny]

The UX needs more thinking. Could we currently only support create an issue on the same repository? So that it will be easier that you could jump to a new issue page with quoted content like @lafriks said.

[kdumontnu]

See PR #14406 for improved dropdown alignment.

I tested this on my local system and it works like a charm!

I still prefer adding a button in line with "Resolve conversation" as shown below. Reason being: the workflow for the user is more clear. That is, a developer has 3 options to handle a conversation:

• Reply - continue the conversation
• Resolve - close the conversation
• Reference - escalate the conversation beyond the scope of the existing thread

Given this, I would also suggest that the "create issue" action does not navigate to the new issue, but instead just closes the modal. I find it actually disrupts the workflow by taking the user away from the original thread, especially given the link will be added below "user referenced this pull request from link to issue X minutes ago".

In any case, these are just my humble opinions, so feel free to take as you wish. I think either way this PR resolves the feature request - I would approve if I had such powers 🥇

[KN4CK3R]

I don't like the thrid button because there isn't much space. If the conversation was marked as resolved the text gets broken etc.

What do you think about this?

In the drop down menu the button doesn't take additional space.

[kdumontnu]

I don't like the thrid button because there isn't much space. If the conversation was marked as resolved the text gets broken etc.

I would apply white-space: nowrap to the text handle that case in general (probably also needs a little margin above)

What do you think about this?

I think it's better than in the context menu, but still a bit confusing. I would remove "conversation" from the copy. Honestly, I think it could be removed from the previous button too.

As before, if you're uncomfortable with these changes I can try to apply them in a future PR.

[KN4CK3R]

I am undecided. Personally I like the drop down menu.