Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fileheader sticky in diffs #14616

Merged
merged 10 commits into from Feb 11, 2021
Merged

Make fileheader sticky in diffs #14616

merged 10 commits into from Feb 11, 2021

Conversation

vnkmpf
Copy link
Contributor

@vnkmpf vnkmpf commented Feb 8, 2021 •
edited by zeripath

Make filenames sticky in PR and commits.

Fix #12552

@zeripath zeripath changed the title Make fileheader sticky: #12552 Make fileheader sticky in diffs Feb 8, 2021
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 9, 2021
@vnkmpf
Copy link
Contributor Author

vnkmpf commented Feb 9, 2021

Some screenshots for review:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2021
@zeripath
Copy link
Contributor

zeripath commented Feb 9, 2021

do you know how this behaves on a mobile?

6543 and others added 3 commits February 10, 2021 18:22
@6543
Merge branch 'master' into sticky-filename
b99b85e
@vnkmpf
Remove sticky filenames when width is 480px or less
8a3634c 
On mobile phone sticky filename is hidden due to the combination
of many possible widths and lengths.
@vnkmpf
Merge branch 'sticky-filename' of github.com:vnkmpf/gitea into sticky…
66d2b48 
…-filename
@vnkmpf
Copy link
Contributor Author

vnkmpf commented Feb 10, 2021

Got the opportunity to test it on real mobile phone.
In landscape mode it works well. In portrait mode it was covered by sticky stats.
Because of many possible problems with small resolutions, I decided under 480px it's OK not to have sticky filenames (as stated in new commit).
Do you share this opinion?

@zeripath
Copy link
Contributor

that seems reasonable to me.

@zeripath
Copy link
Contributor

Can merge the two PRs?

@vnkmpf
Copy link
Contributor Author

vnkmpf commented Feb 10, 2021 •
edited

If you mean this one and #14635 , then sure.

EDIT: maybe I misunderstood. Am I supposed to merge them together and push here?

@zeripath
Copy link
Contributor

yeah just merge them into here.

vnkmpf and others added 3 commits February 10, 2021 21:53
@vnkmpf
Fix text color for .markdown-info
db773a6
@vnkmpf
Fix visual of sticky diff box on 480px or less
5ab3ec4 
- Hide arrow for select buttons.
- Fix changes, additions and deletions.
With flexbox they look very broken.
This commit hides some words to, so the result is:
"123 changed files  987 additions  456 deletions"
- center text in buttons
@zeripath @vnkmpf
fix lint
7854594
@vnkmpf
Copy link
Contributor Author

vnkmpf commented Feb 10, 2021

Commits merged here

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2021
@lafriks lafriks added this to the 1.14.0 milestone Feb 10, 2021
@vnkmpf vnkmpf mentioned this pull request Feb 11, 2021
Closed
@6543
Copy link
Member

6543 commented Feb 11, 2021

🚀

@6543 6543 merged commit 441f3f0 into go-gitea:master Feb 11, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

[Feature] Sticky fileheader when code reviewing
6 participants
@vnkmpf @zeripath @6543 @lafriks @techknowlogick @GiteaBot