Fix bug when combine label comments #14894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Mar 5, 2021
GiteaBot
added
the
lgtm/need 1
|
might just be worth adding some comments - it's just about understandable without them - but the lack of comments originally is likely what led to the missed case in the first place. |
lunny
force-pushed
the
lunny/fix_label_combine
branch
from
4f69e78
to
d40431d
Compare
Added some code comments. |
6543
added
the
skip-changelog
6543
approved these changes
Mar 5, 2021
GiteaBot
added
lgtm/done
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous combine label comments missed a situation that is a non-label comment between two label comment and the comments post time is near by.
Fix #13923