Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide mechanism for configuring submodule aliases #15180

Closed

Conversation

zeripath
Copy link
Contributor

Sometimes Gitea users would like submodules when displayed on the website to have
a different alias than what is normally inferred by gitea.

This PR provides a mechanism to configure this.

Fix #15178

Signed-off-by: Andrew Thornton art27@cantab.net

Sometimes Gitea users would like submodules when displayed on the website to have
a different alias than what is normally inferred by gitea.

This PR provides a mechanism to configure this.

Fix go-gitea#15178

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 27, 2021
@zeripath zeripath added this to the 1.15.0 milestone Mar 27, 2021
@lunny
Copy link
Member

lunny commented Apr 12, 2021

Or we could have a configuration on repository setting UI.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2021
@zeripath
Copy link
Contributor Author

Or we could have a configuration on repository setting UI.

Yes, were would need a common repository settings table:

type Setting struct {
  ID int64
  UserID int64
  RepoID int64
  Key string
  Value string
}

Which could be used to store per user/per repo settings, with Key, RepoID and UserID forming an unique index.

Then we can remove some crap from repo and user, and allow other common settings

@zeripath zeripath mentioned this pull request May 9, 2021
12 tasks
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2021
@zeripath
Copy link
Contributor Author

conflicts resolved @6543

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #15180 (3ab1816) into main (2f725cb) will increase coverage by 0.03%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15180      +/-   ##
==========================================
+ Coverage   45.44%   45.47%   +0.03%     
==========================================
  Files         710      710              
  Lines       83880    83917      +37     
==========================================
+ Hits        38122    38165      +43     
+ Misses      39618    39612       -6     
  Partials     6140     6140              
Impacted Files Coverage Δ
modules/setting/git.go 13.33% <8.33%> (-20.00%) ⬇️
modules/git/submodule.go 72.00% <68.00%> (-2.00%) ⬇️
models/repo_mirror.go 58.69% <0.00%> (-10.87%) ⬇️
services/mirror/mirror.go 9.61% <0.00%> (-7.70%) ⬇️
modules/cron/tasks_basic.go 85.43% <0.00%> (-2.92%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/queue/workerpool.go 53.81% <0.00%> (-1.15%) ⬇️
services/pull/pull.go 41.99% <0.00%> (ø)
routers/api/v1/repo/pull.go 31.08% <0.00%> (+0.53%) ⬆️
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f725cb...3ab1816. Read the comment docs.

zeripath and others added 2 commits July 2, 2021 10:21
@zeripath
Copy link
Contributor Author

zeripath commented Jul 3, 2021

conflicts fixed again

@zeripath zeripath modified the milestones: 1.15.0, 1.16.0 Jul 13, 2021
@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 19, 2021
@stale
Copy link

stale bot commented May 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label May 1, 2022
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 25, 2022
@stale stale bot removed the issue/stale label May 25, 2022
@lunny
Copy link
Member

lunny commented May 25, 2022

Or we could have a configuration on repository setting UI.

Yes, were would need a common repository settings table:

type Setting struct {
  ID int64
  UserID int64
  RepoID int64
  Key string
  Value string
}

Which could be used to store per user/per repo settings, with Key, RepoID and UserID forming an unique index.

Then we can remove some crap from repo and user, and allow other common settings

Let's wait for that PR #22500 merged first.

@lunny lunny modified the milestones: 1.17.0, 1.x.x May 25, 2022
@lunny lunny removed this from the 1.x.x milestone Jan 18, 2023
@zeripath zeripath closed this May 7, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong link to submodule in WebUI
7 participants