Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn RepoRef and RepoAssignment back into func(*Context) (#15372) #15377

Merged
merged 2 commits into from Apr 10, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 9, 2021

Backport #15372

Signed-off-by: Andrew Thornton art27@cantab.net

)

Backport go-gitea#15372

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Apr 9, 2021
@zeripath zeripath mentioned this pull request Apr 9, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 9, 2021
@techknowlogick
Copy link
Member

To Anyone reviewing this: to make it easier to review turn off whitespace changes.

@zeripath
Copy link
Contributor Author

zeripath commented Apr 9, 2021

Yeah sorry about that!

One major benefit of this pr is substantially reducing the indentation of those functions.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 67a12b8 into go-gitea:release/v1.14 Apr 10, 2021
@zeripath zeripath deleted the backport-15372-v1.14 branch April 10, 2021 06:08
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants