Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused vendor packages #1620

Merged
merged 1 commit into from
Apr 27, 2017
Merged

remove unused vendor packages #1620

merged 1 commit into from
Apr 27, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 27, 2017

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 27, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 27, 2017
@sapk
Copy link
Member

sapk commented Apr 27, 2017

LGTM. By curiosity how do you found them ?

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 27, 2017
@lunny
Copy link
Member Author

lunny commented Apr 27, 2017

govendor list and if you found vu mark before a package. u means unused.

@sapk
Copy link
Member

sapk commented Apr 27, 2017

Strange that there not listed in govendor status +outside +unused

@sapk
Copy link
Member

sapk commented Apr 27, 2017

My mistake govendor status -> "Lists any packages missing, out-of-date, or modified locally." but not the unused ...

@sapk sapk mentioned this pull request Apr 27, 2017
Merged
@appleboy
Copy link
Member

LGTM

@appleboy
Copy link
Member

make L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2017
@appleboy appleboy merged commit e3c2963 into go-gitea:master Apr 27, 2017
@lunny lunny deleted the lunny/rm_unused_vendors branch April 27, 2017 11:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @sapk @appleboy @tboerger