Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note about minimum required version of git installed #16433

Merged
merged 1 commit into from Jul 15, 2021
Merged

add note about minimum required version of git installed #16433

merged 1 commit into from Jul 15, 2021

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 15, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2021
Etzelia
Etzelia approved these changes Jul 15, 2021
View reviewed changes
Copy link

@Etzelia Etzelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a note in the admin config page and/or logs would also be beneficial, but that can be a different PR.
LGTM

jolheiser
jolheiser approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Etzelia 👀

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2021
@techknowlogick techknowlogick changed the title add note about minimum required version of gitea installed add note about minimum required version of git installed Jul 15, 2021
@techknowlogick
Copy link
Member Author

to both @Etzelia @jolheiser 😆 there is a log message already, although yeah there should probably be something in admin.

@techknowlogick techknowlogick merged commit 376fc35 into go-gitea:main Jul 15, 2021
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch July 15, 2021 03:28
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@techknowlogick @AbdulrhmnGhanem
add note about minimum required version of git installed (go-gitea#16433
e044f37 
)
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etzelia Etzelia Etzelia approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@techknowlogick @codecov-commenter @Etzelia @a1012112796 @jolheiser @GiteaBot