fix multiple readme file rendering and fix #1657 #1658
Conversation
| continue | ||
| } | ||
|
|
||
| // TODO: collect all possible README files and show with priority. |
There was a problem hiding this comment.
Yes. This PR will finish the TODO.
routers/repo/view.go
Outdated
| if readmeFile != nil { | ||
| if len(readmes) > 0 { | ||
| var readmeFile *git.Blob | ||
| for _, readme := range readmes { |
There was a problem hiding this comment.
Why re-loop if we stop at first ok. This could be done directly in the first loop at https://github.com/lunny/gitea/blob/d0ddef4e095a8f4e317a6163cb2e955fea254779/routers/repo/view.go#L67 for example ?
This just add an additional test if the file is a good filetype so no need to save them in an array ?
There was a problem hiding this comment.
I found that this add another point that it default to even "bad filetype" if not one good is found.
But this could be implemented directly in the first loop.
There was a problem hiding this comment.
For example in first loop setting directly readmeFile and do directly after
if tp != "" {
break
}
There was a problem hiding this comment.
There was a problem hiding this comment.
@sapk you are right. The type will check which parser could read the README file according ext name. But we also need support README, which should be rendered as a TEXT, so the tp may be empty. But README or README.diskdefine is lower priority than README.md or README.org(this will be implemented at #1527).
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
will fix #1657