Recreate Tables should Recreate indexes on MySQL (#16718) #16740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport go-gitea#16718 The MySQL indexes are not being renamed at the same time as RENAME table despite the CASCADE. Therefore it is probably better to just recreate the indexes instead. Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Aug 19, 2021
GiteaBot
added
the
lgtm/need 1
|
We don't have a 1.14.7 milestone and I'm not certain if we want to release one. I guess if we think we're almost ready to release v1.15.0 then I think we can leave this but if not we should merge and release a .7 |
techknowlogick
approved these changes
Aug 21, 2021
GiteaBot
added
lgtm/done
|
@zeripath as in the past, we don't always release a minor version when a new major version is released. I think either way it's fine to merge this in case someone wishes to build this version themselves. You've already taken the effort to backport it, doesn't hurt to merge :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 2, 2021
## [1.14.7](https://github.com/go-gitea/gitea/releases/tag/v1.14.7) - 2021-09-02 * BUGFIXES * Add missing gitRepo close at GetDiffRangeWithWhitespaceBehavior (Partial go-gitea#16894) (go-gitea#16896) * Fix wiki raw commit diff/patch view (go-gitea#16891) (go-gitea#16893) * Ensure wiki repos are all closed (go-gitea#16886) (go-gitea#16889) * Upgrade xorm to v1.2.2 (go-gitea#16663) & Add test to ensure that dumping of login sources remains correct (go-gitea#16847) (go-gitea#16849) * Recreate Tables should Recreate indexes on MySQL (go-gitea#16718) (go-gitea#16740) Signed-off-by: Andrew Thornton <art27@cantab.net>
Merged
zeripath
added a commit
that referenced
this pull request
Sep 2, 2021
## [1.14.7](https://github.com/go-gitea/gitea/releases/tag/v1.14.7) - 2021-09-02 * BUGFIXES * Add missing gitRepo close at GetDiffRangeWithWhitespaceBehavior (Partial #16894) (#16896) * Fix wiki raw commit diff/patch view (#16891) (#16893) * Ensure wiki repos are all closed (#16886) (#16889) * Upgrade xorm to v1.2.2 (#16663) & Add test to ensure that dumping of login sources remains correct (#16847) (#16849) * Recreate Tables should Recreate indexes on MySQL (#16718) (#16740) Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 2, 2021
* BUGFIXES * Add missing gitRepo close at GetDiffRangeWithWhitespaceBehavior (Partial go-gitea#16894) (go-gitea#16896) * Fix wiki raw commit diff/patch view (go-gitea#16891) (go-gitea#16893) * Ensure wiki repos are all closed (go-gitea#16886) (go-gitea#16889) * Upgrade xorm to v1.2.2 (go-gitea#16663) & Add test to ensure that dumping of login sources remains correct (go-gitea#16847) (go-gitea#16849) * Recreate Tables should Recreate indexes on MySQL (go-gitea#16718) (go-gitea#16740) Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
pushed a commit
that referenced
this pull request
Sep 2, 2021
* BUGFIXES * Add missing gitRepo close at GetDiffRangeWithWhitespaceBehavior (Partial #16894) (#16896) * Fix wiki raw commit diff/patch view (#16891) (#16893) * Ensure wiki repos are all closed (#16886) (#16889) * Upgrade xorm to v1.2.2 (#16663) & Add test to ensure that dumping of login sources remains correct (#16847) (#16849) * Recreate Tables should Recreate indexes on MySQL (#16718) (#16740) Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #16718 on to 1.14
The MySQL indexes are not being renamed at the same time as RENAME table despite the
CASCADE. Therefore it is probably better to just recreate the indexes instead.
Signed-off-by: Andrew Thornton art27@cantab.net