Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of issue checkboxes #1709

Merged
merged 1 commit into from
May 12, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

Fixes #1541. Basically just use span instead of div.

image

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2017
@lunny lunny added this to the 1.2.0 milestone May 12, 2017
@sapk
Copy link
Member

sapk commented May 12, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2017
@appleboy appleboy merged commit 5ca3046 into go-gitea:master May 12, 2017
@ethantkoenig ethantkoenig deleted the checkbox branch May 12, 2017 14:45
ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request May 30, 2017
@lunny
Copy link
Member

lunny commented Aug 10, 2017

Could anyone backport this to release/v1.1 ?

appleboy added a commit to appleboy/gitea that referenced this pull request Aug 11, 2017
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
appleboy added a commit to appleboy/gitea that referenced this pull request Aug 11, 2017
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
lunny pushed a commit that referenced this pull request Aug 11, 2017
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@lunny lunny added the backport/done All backports for this PR have been created label Aug 11, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix checkbox rendering in issues
5 participants