Add API to get commit diff/patch

[qwerty287]

This PR adds an API endpoint to get the diff or patch file of a commit. It uses the same mechanism as the "site" <host>/<owner>/<repo>/commit/<sha>.<diff or patch>.

Endpoints:
Get diff /repos/{owner}/{repo}/git/commits/{sha}.diff
Get patch /repos/{owner}/{repo}/git/commits/{sha}.patch

Could close #10921 #13012

[6543]

could you write a very simple integration test (one download of a patch and one for diff) ...
If you need help just ask

[qwerty287]

Is 67ebe50 enough? (test contains an error, will fix it asap)

[codecov-commenter]

Codecov Report

Merging #17095 (283adfc) into main (a4bfef2) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main   #17095      +/-   ##
==========================================
- Coverage   45.25%   45.25%   -0.01%     
==========================================
  Files         773      773              
  Lines       86828    86842      +14     
==========================================
+ Hits        39291    39297       +6     
+ Misses      41188    41187       -1     
- Partials     6349     6358       +9     

Impacted Files	Coverage Δ
routers/api/v1/repo/commits.go	54.73% <53.84%> (-0.15%)	⬇️
routers/api/v1/api.go	78.22% <100.00%> (+0.02%)	⬆️
modules/queue/queue_channel.go	91.66% <0.00%> (-3.34%)	⬇️
modules/git/repo_base_nogogit.go	82.85% <0.00%> (-2.86%)	⬇️
modules/git/utils.go	68.05% <0.00%> (-2.78%)	⬇️
modules/queue/workerpool.go	47.32% <0.00%> (-1.91%)	⬇️
models/issue_comment.go	51.31% <0.00%> (-0.59%)	⬇️
models/unit.go	43.83% <0.00%> (+2.73%)	⬆️
modules/git/diff.go	80.64% <0.00%> (+5.37%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4bb8e0...283adfc. Read the comment docs.

[qwerty287]

Just a question, nothing that should be done in this PR: as @6543 suggested, I merged the two endpoints into one. Is there a certain reason why there are two endpoints for the PRs? One for diff and one for patch? To keep it consistent, it may be good to merge them into one.

[axifive]

@qwerty287 as I can see they can be merged too

[6543]

Just a question, nothing that should be done in this PR: as @6543 suggested, I merged the two endpoints into one. Is there a certain reason why there are two endpoints for the PRs? One for diff and one for patch? To keep it consistent, it may be good to merge them into one.

it would be breaking in terms of swagger doc but not for api - so I would say it's good to go

yes if you would open another pull I'm happy to look at it

[qwerty287]

Ok I think I'd like to do this