Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct defaultValue for stracktrace #17552

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Use correct defaultValue for stracktrace #17552

merged 1 commit into from
Nov 5, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 5, 2021

  • use defaultValue argument instead of "none" to be passed to MustString.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2021
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 5, 2021
@lafriks lafriks added this to the 1.16.0 milestone Nov 5, 2021
@lafriks lafriks merged commit bc6df18 into go-gitea:main Nov 5, 2021
@lunny
Copy link
Member

lunny commented Nov 5, 2021

@Gusted Please send backport to release/v1.15

Gusted added a commit to Gusted/gitea that referenced this pull request Nov 5, 2021
@Gusted
backport(1.15): Use correct defaultValue for stracktrace
fe293ae 
- Backporting go-gitea#17552
@Gusted Gusted mentioned this pull request Nov 5, 2021
Merged
@Gusted
Copy link
Contributor Author

Gusted commented Nov 5, 2021

@Gusted Please send backport to release/v1.15

@lunny Done, #17557

wxiaoguang pushed a commit that referenced this pull request Nov 5, 2021
@Gusted
backport(1.15): Use correct defaultValue for stracktrace (#17557)
0d0ff5e 
- Backporting #17552
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 25, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@Gusted
Use correct defaultValue for stracktrace (go-gitea#17552)
f1afa7e
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Gusted @lunny @lafriks @wxiaoguang @zeripath @GiteaBot