Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for BIDI characters in page renders and in diffs #17562

Merged
merged 47 commits into from
Jan 7, 2022
Merged

Add warning for BIDI characters in page renders and in diffs #17562

merged 47 commits into from
Jan 7, 2022

Commits on Nov 5, 2021

  1. Add warning for BIDI characters in page renders and in diffs 

    Fix go-gitea#17514

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dca05ee View commit details
    Browse the repository at this point in the history

  2. as per review 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    449cb26 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. Adjust to only put the warning on BIDI lines without RTL chars 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    40b8628 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Another attempt. 

    Here we detect if there are examples of bad bidi behaviour and render an
error for those, but otherwise we will attempt to detect all zero-widtah
characters, combining characters, unusual spaces and control characters
and will render these with an escape and unescaped form. (In particular
this allows for the detection of pages that contain á and á.)

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    3a63d9d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    cd0bb29 View commit details
    Browse the repository at this point in the history

  2. placate lint 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    5f481cf View commit details
    Browse the repository at this point in the history

  3. another placation 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    c89c678 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    7e9871c View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. as per review 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    f563ee9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    70d446b View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    65dcc39 View commit details
    Browse the repository at this point in the history

  2. fix broken merge 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    62345ba View commit details
    Browse the repository at this point in the history

  3. as per silverwind 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    831f189 View commit details
    Browse the repository at this point in the history

  4. as per silverwind 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    5a9759c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    006a5cd View commit details
    Browse the repository at this point in the history

  6. fix class

    @silverwind
    silverwind committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    63a5e0f View commit details
    Browse the repository at this point in the history

  7. make message header colors work on both themes

    @silverwind
    silverwind committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8a01b22 View commit details
    Browse the repository at this point in the history

  8. minor styling tweaks

    @silverwind
    silverwind committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    6449cad View commit details
    Browse the repository at this point in the history

  9. fix border-radius on unescape button

    @silverwind
    silverwind committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    ab03673 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    06b4146 View commit details
    Browse the repository at this point in the history

  2. drop buttons as per silverwind 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    b93d0bf View commit details
    Browse the repository at this point in the history

  3. as per fnetx 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    cf04f2e View commit details
    Browse the repository at this point in the history

  4. hide the unescape button in the wiki 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    aa4fc5a View commit details
    Browse the repository at this point in the history

  5. add warning triangles to view and blame 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    62f557d View commit details
    Browse the repository at this point in the history

  6. Add warning triangles to diff 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    b6ba958 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    ea7a04a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2021

  1. Merge branch 'main' into fix-17514-add-warning-bidi-characters

    @zeripath
    zeripath committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    36dd4bf View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    19aed47 View commit details
    Browse the repository at this point in the history

  2. ensure buttons work on loaded diffs 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    6a2e274 View commit details
    Browse the repository at this point in the history

  3. move escape functions into their own files 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    0d6e8f6 View commit details
    Browse the repository at this point in the history

  4. extract out functions 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    cb7d19d View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @zeripath
    zeripath committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c55394d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    ae19a60 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Update options/locale/locale_en-US.ini 

    Co-authored-by: Gwyneth Morgan <gwymor@tilde.club>
    @zeripath @gwymor
    zeripath and gwymor committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    c11bd34 View commit details
    Browse the repository at this point in the history

  2. move warning triangle to another column 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    58a4fcc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fix-17514-add-warning… 

    …-bidi-characters
    @zeripath
    zeripath committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    3f6057e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Merge branch 'main' into fix-17514-add-warning-bidi-characters

    @6543
    6543 committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    67d00b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Merge branch 'main' into fix-17514-add-warning-bidi-characters

    @6543
    6543 committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    51a1bf1 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Merge branch 'master' into fix-17514-add-warning-bidi-characters

    @6543
    6543 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d8ab670 View commit details
    Browse the repository at this point in the history

  2. linter ignore bool "suspicious assignment to a by-value method receiv… 

    …er" error
    @6543
    6543 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    0fc5af7 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @wxiaoguang
    wxiaoguang committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    1dc8a21 View commit details
    Browse the repository at this point in the history

  4. refactoring

    @wxiaoguang
    wxiaoguang committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    6f99bfd View commit details
    Browse the repository at this point in the history

  5. refactor

    @wxiaoguang
    wxiaoguang committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    ab6db78 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @zeripath
    zeripath committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    4e1b449 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #10 from wxiaoguang/fix-17514-add-warning-bidi-cha… 

    …racters

refactoring fix-17514-add-warning-bidi-characters
    @zeripath
    zeripath committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    aac0e1d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into fix-17514-add-warning-bidi-characters

    @6543
    6543 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    f66923f View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Merge branch 'main' into fix-17514-add-warning-bidi-characters

    @wxiaoguang
    wxiaoguang committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    a28bbbc View commit details
    Browse the repository at this point in the history