Send commit object in http response header for archives #17923
Conversation
lafriks
changed the title
|
You need to run make fmt |
GiteaBot
added
the
lgtm/need 2
|
Why not just send the sha instead? |
| // We use base64 to ensure a lossless encoding of binary data. | ||
| // test: gitea/integrations/repo_download_test.go | ||
| func addCommitObjectResponseHeader(ctx *context.Context, archiver *repo_model.RepoArchiver) { | ||
| if ctx.Req.Header.Get("X-Commit-Object") != "1" { |
There was a problem hiding this comment.
Using X-Commit-Object for different purpose in request and response is not a good idea.
HTTP has Content-Length in request and response, it has the same meaning.
But now the X-Commit-Object is used for different meaning. I think we can make it like this:
request:
X-Request-Extra-Info: commit-id
response:
X-Extra-Commit-ID: .....
If we want to add more options, we can extend: X-Request-Extra-Info: commit-message, commit-author ...
There was a problem hiding this comment.
is not a good idea
why not?
If we want to add more options
then we can add more headers
keep it simple : )
There was a problem hiding this comment.
why not?
As explained, the X-Commit-Object has different meanings, will mislead users and developers.
keep it simple : )
I don't think X-Request-Extra-Info + X-Extra-Commit-ID is more complex than X-Commit-Object + X-Commit-Object.
There was a problem hiding this comment.
thanks for your opinion, but youre just wasting my time. bye : )
There was a problem hiding this comment.
unresolve
its interesting that bad taste and hostage-taking so often appear together.
probably both are facets of the same personality type (conservative)
in the real world, i would kill the tyrant, and install someone who is "less bad".
in the digital world? lets just pretend this never happened ... "muh ideals!"
There was a problem hiding this comment.
unresolve
its interesting that bad taste and hostage-taking so often appear together.
probably both are facets of the same personality type (conservative)
in the real world, i would kill the tyrant, and install someone who is "less bad".
in the digital world? lets just pretend this never happened ... "muh ideals!"
Are you talking about yourself?
For me, I feel fine. I submitted some PRs, approved many PRs and helped some contributors to improve their PRs, like #17152, #17900, #17929, etc.
If you don't like my suggestions, that's your choice. I won't waste time on non-sense communications.
We can keep this review open and let everyone read it.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
It has been stale for long time and doesn't get interest or update. I will close it. You are always welcome if there could be a open and friendly discussion. |
fix #17834
demo