Move repository model into models/repo #17933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
lunny
force-pushed
the
lunny/repo_refactor
branch
2 times, most recently
from
708860a
to
4e5658d
Compare
|
It would be better to keep model related prefix for functions in root For example, And Otherwise, LGTM |
GiteaBot
added
the
lgtm/need 1
I changed most of them but kept |
wxiaoguang
approved these changes
Dec 9, 2021
KN4CK3R
reviewed
Dec 9, 2021
KN4CK3R
approved these changes
Dec 9, 2021
GiteaBot
added
lgtm/done
lunny
force-pushed
the
lunny/repo_refactor
branch
from
418fee0
to
7ac88ae
Compare
Codecov Report
@@ Coverage Diff @@
## main #17933 +/- ##
==========================================
+ Coverage 45.34% 45.37% +0.03%
==========================================
Files 815 817 +2
Lines 90768 90806 +38
==========================================
+ Hits 41157 41206 +49
+ Misses 43045 43036 -9
+ Partials 6566 6564 -2
Continue to review full report at Codecov.
|
zeripath
reviewed
Jan 7, 2022
| @@ -361,21 +364,24 @@ func repoAssignment(ctx *Context, repo *models.Repository) { | |||
|
|
|||
| if repo.IsMirror { | |||
| var err error | |||
| ctx.Repo.Mirror, err = models.GetMirrorByRepoID(repo.ID) | |||
| mirror, err := repo_model.GetMirrorByRepoID(repo.ID) | |||
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 7, 2022
In go-gitea#17933 repoAssignment no longer sets the ctx.Repo.Mirror field meaning that attempting change mirror settings results in an NPE. This PR simply restores this. Either we should remove this field or, we should set it. At present it seems simplest to set it instead of going looking in the Data for the value although converting the context to a bag of things may be the correct approach in the future. Fix go-gitea#18204 Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
pushed a commit
that referenced
this pull request
Jan 8, 2022
In #17933 repoAssignment no longer sets the ctx.Repo.Mirror field meaning that attempting change mirror settings results in an NPE. This PR simply restores this. Either we should remove this field or, we should set it. At present it seems simplest to set it instead of going looking in the Data for the value although converting the context to a bag of things may be the correct approach in the future. Fix #18204 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Some refactors related repository model * Move more methods out of repository * Move repository into models/repo * Fix test * Fix test * some improvements * Remove unnecessary function
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
In go-gitea#17933 repoAssignment no longer sets the ctx.Repo.Mirror field meaning that attempting change mirror settings results in an NPE. This PR simply restores this. Either we should remove this field or, we should set it. At present it seems simplest to set it instead of going looking in the Data for the value although converting the context to a bag of things may be the correct approach in the future. Fix go-gitea#18204 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to move repository related beans. To make it review easier, I will put others in future PRs.