Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webhooks i18n #18380

Merged
merged 1 commit into from Jan 24, 2022
Merged

Refactor webhooks i18n #18380

merged 1 commit into from Jan 24, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 24, 2022 •
edited

This PR fixes the following problems:

  1. Use generalized i18n message for webhooks
  2. Use <a target="_blank" rel="noreferrer"> instead of <a>
  3. Use correct webhook names for Wechat Work / DingTalk
  4. Fix insecure slack URL: http=> https

image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2022
@wxiaoguang wxiaoguang merged commit 5506cb9 into go-gitea:main Jan 24, 2022
@wxiaoguang wxiaoguang deleted the refactor-webhooks-i18n branch January 24, 2022 11:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 24, 2022
@zjjhot
Merge branch 'main' of https://github.com/go-gitea/gitea
ab961b4 
* 'main' of https://github.com/go-gitea/gitea:
  Refactor webhooks i18n (go-gitea#18380)
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Feb 8, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Refactor webhooks i18n (go-gitea#18380)
27dc8a3
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks left review comments

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wxiaoguang @lunny @lafriks @delvh @GiteaBot